Arsnael commented on pull request #504:
URL: https://github.com/apache/james-project/pull/504#issuecomment-864876160
> I think I should add threadId to ComposedMessageIdWithMetaData class.
Hmmm I would say likely yes, or maybe even in `ComposedMessageId`? Should
recheck all the usages... But probably not in this PR though?
> I have some questions:
>
> * What is the meaning of these two tables' name? From my view, it
looks like rather mailbox message table.
Those are projections. If you look in `CassandraMessageModule` where they
are defined, the description says it all:
* `messageIdTable`: Holds mailbox and flags for each message, lookup by
mailbox ID + UID
* `imapUidTable`: Holds mailbox and flags for each message, lookup by
message ID
> * What is IMAP Uid?
https://datatracker.ietf.org/doc/html/rfc3501#section-2.3.1.1
To be simple here, IMAP UID is the ID message when using IMAP. And we use
the message Id for JMAP
> * I see table messageV2 storing message metadata. Should we add
threadId to this table too?
messageV2 is not used anymore, it's messageV3 ;) But it would make sense to
me to add a field here yes
Oh and don't forget to try adding the migration doc as well later!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
