chibenwa commented on a change in pull request #504:
URL: https://github.com/apache/james-project/pull/504#discussion_r656971949
##########
File path:
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdToImapUidDAO.java
##########
@@ -248,6 +253,7 @@ private ComposedMessageIdWithMetaData
toComposedMessageIdWithMetadata(Row row) {
MessageUid.of(row.getLong(IMAP_UID))))
.flags(FlagsExtractor.getFlags(row))
.modSeq(ModSeq.of(row.getLong(MOD_SEQ_LOWERCASE)))
+
.threadId(ThreadId.fromBaseMessageId(messageIdFactory.of(row.getUUID(THREAD_ID))))
Review comment:
Please handle the null case to allow a smooth upgrade
##########
File path: upgrade-instructions.md
##########
@@ -19,7 +19,22 @@ Change list:
- [Drop Cassandra schema version prior version
8](#drop-cassandra-schema-version-prior-version-8)
- [Adopt UnboundID as a LDAP library](#adopt-unboundid-as-a-ldap-library)
- [Review the architecture of the RabbitMQ event
bus](#review-the-architecture-of-the-rabbitmq-event-bus)
+ - [Cassandra Schema update to V11](#cassandra-schema-update-to-v11)
+### Cassandra Schema update to V11
+
+Date 23/06/2021
+
+JIRA: https://issues.apache.org/jira/browse/JAMES-3516
+
+Concerned product: Distributed James
+
+Add threadId column to messageIdTable and imapUidTable in order to get a
message's threadId.
+
+In order to benefit from this work, you need to [upgrade to the latest schema
version](https://github.com/apache/james-project/blob/master/src/site/markdown/server/manage-webadmin.md#upgrading-to-the-latest-version).
+
+A James restart is advised after this migration in order to skip schema
version reads.
Review comment:
Nope.
##########
File path: upgrade-instructions.md
##########
@@ -19,7 +19,22 @@ Change list:
- [Drop Cassandra schema version prior version
8](#drop-cassandra-schema-version-prior-version-8)
- [Adopt UnboundID as a LDAP library](#adopt-unboundid-as-a-ldap-library)
- [Review the architecture of the RabbitMQ event
bus](#review-the-architecture-of-the-rabbitmq-event-bus)
+ - [Cassandra Schema update to V11](#cassandra-schema-update-to-v11)
+### Cassandra Schema update to V11
Review comment:
```suggestion
### Adding threadId collumn to message metadata tables
```
There's no v11 as we did not define any upgrade task.
##########
File path: upgrade-instructions.md
##########
@@ -19,7 +19,22 @@ Change list:
- [Drop Cassandra schema version prior version
8](#drop-cassandra-schema-version-prior-version-8)
- [Adopt UnboundID as a LDAP library](#adopt-unboundid-as-a-ldap-library)
- [Review the architecture of the RabbitMQ event
bus](#review-the-architecture-of-the-rabbitmq-event-bus)
+ - [Cassandra Schema update to V11](#cassandra-schema-update-to-v11)
+### Cassandra Schema update to V11
+
+Date 23/06/2021
+
+JIRA: https://issues.apache.org/jira/browse/JAMES-3516
+
+Concerned product: Distributed James
+
+Add threadId column to messageIdTable and imapUidTable in order to get a
message's threadId.
+
+In order to benefit from this work, you need to [upgrade to the latest schema
version](https://github.com/apache/james-project/blob/master/src/site/markdown/server/manage-webadmin.md#upgrading-to-the-latest-version).
Review comment:
Wrong. There's no upgrades to do here.
However we need to document how to create the threadId collumn on existing
tables (ALTER TABLE ...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
