ottoka commented on a change in pull request #750:
URL: https://github.com/apache/james-project/pull/750#discussion_r754050152
##########
File path:
protocols/api/src/main/java/org/apache/james/protocols/api/Encryption.java
##########
@@ -29,15 +29,17 @@
private final SSLContext context;
private final boolean starttls;
private final String[] enabledCipherSuites;
+ private Boolean clientAuth;
- private Encryption(SSLContext context, boolean starttls, String[]
enabledCipherSuites) {
+ private Encryption(SSLContext context, boolean starttls, String[]
enabledCipherSuites, Boolean clientAuth) {
Review comment:
Agreed, enums kind of are the Java way to express tri-state or
multi-state logic. But as discussed below, I will remove the unused optional
authentication feature for now, so this will become a simple `boolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
