chibenwa commented on a change in pull request #750:
URL: https://github.com/apache/james-project/pull/750#discussion_r754069352
##########
File path:
protocols/api/src/main/java/org/apache/james/protocols/api/Encryption.java
##########
@@ -29,15 +29,17 @@
private final SSLContext context;
private final boolean starttls;
private final String[] enabledCipherSuites;
+ private Boolean clientAuth;
- private Encryption(SSLContext context, boolean starttls, String[]
enabledCipherSuites) {
+ private Encryption(SSLContext context, boolean starttls, String[]
enabledCipherSuites, Boolean clientAuth) {
Review comment:
Even with too states enums brings in strong typing thus better express
the intent and should rather be used.
(Refs: Clean code book, chapter I don't remember but clearly boolean
arguments should be discouraged.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
