chibenwa commented on a change in pull request #780: URL: https://github.com/apache/james-project/pull/780#discussion_r763983798
########## File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/jmap.adoc ########## @@ -31,36 +31,37 @@ This should not be the same keystore than the ones used by TLS based protocols. Defaults to an empty list. | url.prefix -| Optional. Configuration urlPrefix for JMAP routes. -| Default value: http://localhost. +| Optional. Configuration urlPrefix for JMAP routes. Default value: http://localhost. | websocket.url.prefix -| Optional. URL for JMAP WebSocket route. -| Default value: ws://localhost +| Optional. URL for JMAP WebSocket route. Default value: ws://localhost | email.send.max.size | Optional. Configuration max size for message created in both JMAP Draft amd RFC-8621. -| Default value: None. Supported units are B (bytes) K (KB) M (MB) G (GB). +Default value: None. Supported units are B (bytes) K (KB) M (MB) G (GB). | upload.max.size | Optional. Configuration max size Upload in new JMAP-RFC-8621. -| Default value: 30M. Supported units are B (bytes) K (KB) M (MB) G (GB). +Default value: 30M. Supported units are B (bytes) K (KB) M (MB) G (GB). | view.email.query.enabled -| Optional boolean. Defaults to false. -| Should simple Email/query be resolved against a Cassandra projection, or should we resolve them against ElasticSearch? +| Optional boolean. Defaults to false. Should simple Email/query be resolved against a Cassandra projection, or should we resolve them against ElasticSearch? This enables a higher resilience, but the projection needs to be correctly populated. | user.provisioning.enabled -| Optional boolean. Defaults to true. -| Governs whether authenticated users that do not exist locally should be created in the users repository. +| Optional boolean. Defaults to true. Governs whether authenticated users that do not exist locally should be created in the users repository. | jmap.version.default | Optional string. Defaults to draft. Allowed values: draft, rfc-8621. -| Which version of the JMAP protocol should be served when none supplied in the Accept header. +Which version of the JMAP protocol should be served when none supplied in the Accept header. Defaults to draft for legacy reasons (avoid breaking changes) but setting the value to rfc-8621 allow compatibility with other third party apps. +| dynamic.jmap.prefix.resolution.enabled +| Optional boolean. Defaults to false. Supported Jmap session endpoint return dynamic prefix in response. +When it was config is true, and http request to jmap session endpoint has `X-JMAP-PREFIX` header with value is `/jmapprefix`, then `apiUrl` in response will be "${url.prefix}/jmapprefix/jmap". +Example: http://localhost/jmapprefix/jmap Review comment: IMO we should be more generic and override the url.prefix. Eg: `X-JMAP-PREFIX: http://sub.domainb.tld/prefix` then `apiUrl` in response will be "http://sub.domainb.tld/prefix/jmap";. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
