chibenwa commented on a change in pull request #780:
URL: https://github.com/apache/james-project/pull/780#discussion_r764646957
##########
File path:
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/SessionRoutesContract.scala
##########
@@ -174,108 +175,37 @@ trait SessionRoutesContract {
@Test
def
getResponseShouldReturnUrlEndpointContainJmapPrefixWhenAssignHeaderAndConfigurationProvided():
Unit = {
- val sessionJson: String = `given`()
+ `given`()
+ .header(ACCEPT.toString, ACCEPT_RFC8621_VERSION_HEADER)
+ .header("X-JMAP-PREFIX", "http://new-domain.tld/prefix";)
+ .header("X-JMAP-WEBSOCKET-PREFIX", "ws://new-domain.tld/prefix")
.when()
+ .get("/session").prettyPeek()
Review comment:
debug spotted
##########
File path:
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/SessionSupplier.scala
##########
@@ -68,20 +68,27 @@ class SessionSupplier(val configuration:
JmapRfc8621Configuration, defaultCapabi
.toMap
}
-class JmapUrlEndpointResolver(val configuration: JmapRfc8621Configuration,
jmapPrefixRequest: Option[String] = None) {
+class JmapUrlEndpointResolver(val configuration: JmapRfc8621Configuration,
+ urlPrefixRequest: Option[URL] = None,
+ uriWebSocketPrefixRequest: Option[URI]= None) {
Review comment:
space between = amd ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
