chibenwa commented on a change in pull request #781:
URL: https://github.com/apache/james-project/pull/781#discussion_r764745272
##########
File path: server/apps/cassandra-app/sample-configuration/jmap.properties
##########
@@ -24,7 +24,7 @@ tls.secret=james72laBalle
# view.email.query.enabled=true
# If you want to specified authentication strategies for Jmap draft version
-#
authentication.strategy.draft=org.apache.james.AuthStratA,org.apache.james.AuthStratB
+#
authentication.strategy.draft=org.apache.james.jmap.http.AccessTokenAuthenticationStrategy,org.apache.james.jmap.jwt.JWTAuthenticationStrategy,org.apache.james.jmap.http.QueryParameterAccessTokenAuthenticationStrategy
# If you want to specified authentication strategies for Jmap rfc-8621 version
-#
authentication.strategy.rfc8621=org.apache.james.AuthStratA,org.apache.james.AuthStratB
\ No newline at end of file
+#
authentication.strategy.rfc8621=org.apache.james.jmap.jwt.JWTAuthenticationStrategy,org.apache.james.jmap.http.BasicAuthenticationStrategy
Review comment:
Can we rely on an implicit FQDN prefix to simplify this?
```
#
authentication.strategy.draft=AccessTokenAuthenticationStrategy,JWTAuthenticationStrategy,QueryParameterAccessTokenAuthenticationStrategy
# If you want to specified authentication strategies for Jmap rfc-8621
version
#
authentication.strategy.rfc8621=JWTAuthenticationStrategy,BasicAuthenticationStrategy
```
?
We can easily use `NamingScheme` `OptionalPackagePrefix` alongside with
`GuiceGenericLoader`, use `org.apache.james.jmap.http` as an optional prefix,
and also move `JWTAuthenticationStrategy` to `org.apache.james.jmap.http`
package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
