chibenwa commented on a change in pull request #781:
URL: https://github.com/apache/james-project/pull/781#discussion_r765430965



##########
File path: src/site/xdoc/server/config-jmap.xml
##########
@@ -88,13 +88,15 @@
                     <dd>List[String] with delimiter ",". Defaults to 
AccessTokenAuthenticationStrategy,JWTAuthenticationStrategy,
                         QueryParameterAccessTokenAuthenticationStrategy.</dd>
                     <dd>Specify which authentication strategies system admin 
want to use for JMAP draft server.
-                    If non is specified, JMAP draft server will fallback to 
default strategies:
+                        The implicit package name is 
"org.apache.james.jmap.http". If you have a custom authentication strategy 
outside this package, you have to specify its FQDN.
+                        If non authentication strategy is specified, JMAP 
draft server will fallback to default strategies:

Review comment:
       ```suggestion
                           If no authentication strategy is specified, JMAP 
draft server will fallback to default strategies:
   ```

##########
File path: 
server/apps/distributed-app/docs/modules/ROOT/pages/configure/jmap.adoc
##########
@@ -58,13 +58,15 @@ This enables a higher resilience, but the projection needs 
to be correctly popul
 
 | authentication.strategy.draft
 | Optional List[String] with delimiter `,` . Specify which authentication 
strategies system admin want to use for JMAP draft server.
-If non is specified, JMAP draft server will fallback to default strategies:
+The implicit package name is `org.apache.james.jmap.http`. If you have a 
custom authentication strategy outside this package, you have to specify its 
FQDN.
+If non authentication strategy is specified, JMAP draft server will fallback 
to default strategies:

Review comment:
       ```suggestion
   If no authentication strategy is specified, JMAP draft server will fallback 
to default strategies:
   ```

##########
File path: src/site/xdoc/server/config-jmap.xml
##########
@@ -88,13 +88,15 @@
                     <dd>List[String] with delimiter ",". Defaults to 
AccessTokenAuthenticationStrategy,JWTAuthenticationStrategy,
                         QueryParameterAccessTokenAuthenticationStrategy.</dd>
                     <dd>Specify which authentication strategies system admin 
want to use for JMAP draft server.
-                    If non is specified, JMAP draft server will fallback to 
default strategies:
+                        The implicit package name is 
"org.apache.james.jmap.http". If you have a custom authentication strategy 
outside this package, you have to specify its FQDN.
+                        If non authentication strategy is specified, JMAP 
draft server will fallback to default strategies:
                     AccessTokenAuthenticationStrategy, 
JWTAuthenticationStrategy, QueryParameterAccessTokenAuthenticationStrategy.</dd>
 
                     <dt><strong>authentication.strategy.rfc8621</strong></dt>
                     <dd>List[String] with delimiter ",". Defaults to 
JWTAuthenticationStrategy,BasicAuthenticationStrategy.</dd>
                     <dd>Specify which authentication strategies system admin 
want to use for JMAP RFC-8621 server.
-                    If non is specified, JMAP RFC-8621 server will fallback to 
default strategies:
+                        The implicit package name is 
"org.apache.james.jmap.http". If you have a custom authentication strategy 
outside this package, you have to specify its FQDN.
+                        If non authentication strategy is specified, JMAP 
RFC-8621 server will fallback to default strategies:

Review comment:
       ```suggestion
                           If no authentication strategy is specified, JMAP 
RFC-8621 server will fallback to default strategies:
   ```

##########
File path: 
server/apps/distributed-app/docs/modules/ROOT/pages/configure/jmap.adoc
##########
@@ -58,13 +58,15 @@ This enables a higher resilience, but the projection needs 
to be correctly popul
 
 | authentication.strategy.draft
 | Optional List[String] with delimiter `,` . Specify which authentication 
strategies system admin want to use for JMAP draft server.
-If non is specified, JMAP draft server will fallback to default strategies:
+The implicit package name is `org.apache.james.jmap.http`. If you have a 
custom authentication strategy outside this package, you have to specify its 
FQDN.
+If non authentication strategy is specified, JMAP draft server will fallback 
to default strategies:
 `AccessTokenAuthenticationStrategy`, `JWTAuthenticationStrategy`, 
`QueryParameterAccessTokenAuthenticationStrategy`
 
 | authentication.strategy.rfc8621
 | Optional List[String] with delimiter `,` . Specify which authentication 
strategies system admin want to use for JMAP RFC-8621 server.
-If non is specified, JMAP RFC-8621 server will fallback to default strategies:
-`JWTAuthenticationStrategy`, `BasicAuthenticationStrategy`
+The implicit package name is `org.apache.james.jmap.http`. If you have a 
custom authentication strategy outside this package, you have to specify its 
FQDN.
+If non authentication strategy is specified, JMAP RFC-8621 server will 
fallback to default strategies:

Review comment:
       ```suggestion
   If no authentication strategy is specified, JMAP RFC-8621 server will 
fallback to default strategies:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to