chibenwa commented on pull request #831: URL: https://github.com/apache/james-project/pull/831#issuecomment-1007882993
> I suggest not starting a third discussion on the same topic. Fair. But failing tests have added value and shows fonctionnal expectations I have. It also makes the whole discussion less abstract (and show I care enough to dedicate a bit of time to the topic). I do not feel like this just is valueless conversation duplication. BTW it proved we have two distinct problems while the design review only allowed to catch one! > so we implemented the simplest that passed the contracts :) I have limited faight in these contracts, delays is not an area covered by the previous RabbitMQ implementation and we did devote limited amount of time testing edge cases, interactions with other MailQueue features. It should not be taken as "written in marble". > attach a monotonously increasing identifier such as a timestamp That's what I meant by "We would likely need the sequence to be backed by some applicative metadata - like a timestamp?". Of course it brings additional problems like accounting for imperfect clock synchronisation with a tolerated clock skew. > query the scheduled topic offset on filter creation and attach that to the filter in addition to the out topic offset. filter scheduled messages as they are consumed and before they are requeued in the out topic. a filter would then expire when both the out topic and the scheduled topic's offset have been exceeded. (a simple way to implement this with the current setup is to duplicate the filter actor and the filter command queue and reuse the existing logic for the scheduled queue) :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
