jeantil commented on pull request #831: URL: https://github.com/apache/james-project/pull/831#issuecomment-1010568448
My bad. I shouldn't have tried to do the review while managing the kids. Le mar. 11 janv. 2022 à 16:24, Benoit TELLIER ***@***.***> a écrit : > ***@***.**** commented on this pull request. > ------------------------------ > > In > server/queue/queue-pulsar/src/test/java/org/apache/james/queue/pulsar/PulsarMailQueueTest.java > <https://github.com/apache/james-project/pull/831#discussion_r782254109>: > > > + @Test > + @Override > + @Disabled("JAMES-3687 Delayed deletes are buggy") > + public void delayedEmailsShouldBeDeleted() { > + > + } > + > + @Test > + @Override > + @Disabled("JAMES-3687 Delayed deletes are buggy") > + public void delayedEmailsShouldBeDeletedWhenMixedWithOtherEmails() { > + > + } > > you will need to @disable <https://github.com/disable> them in the > PulsarMailqueueTest, we will enable them again when we merge (adding the > @disabled <https://github.com/disabled> will ensure we get a conflict > when rebasing :) > > Isn't this done here? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/james-project/pull/831#pullrequestreview-849334374>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAFTQ3ADH7SEQJP6HIIYO3UVRDSDANCNFSM5LPEZ2PA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
