ff-wl commented on a change in pull request #886:
URL: https://github.com/apache/james-project/pull/886#discussion_r808754604
##########
File path:
server/protocols/protocols-imap4/src/test/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoderTest.java
##########
@@ -46,35 +37,35 @@ void setUp() {
18);
}
- @Test
- void newCumulationBufferShouldNotThrowWhenNoAttachments() {
- ChannelHandlerContext channelHandler =
mock(ChannelHandlerContext.class);
- Channel channel = mock(Channel.class);
- ChannelConfig channelConfig = mock(ChannelConfig.class);
+// @Test
+// void newCumulationBufferShouldNotThrowWhenNoAttachments() {
+// ChannelHandlerContext channelHandler =
mock(ChannelHandlerContext.class);
+// Channel channel = mock(Channel.class);
+// ChannelConfig channelConfig = mock(ChannelConfig.class);
+//
+// //
when(channelConfig.getBufferFactory()).thenReturn(mock(ChannelBufferFactory.class));
+// when(channelHandler.channel()).thenReturn(channel);
+// when(channel.config()).thenReturn(channelConfig);
+//
+//
when(channelHandler.getAttachment()).thenReturn(ImmutableMap.<String,
Object>of());
+//
+// assertThatCode(() -> testee.newCumulationBuffer(channelHandler, 36))
+// .doesNotThrowAnyException();
+// }
Review comment:
fixed
##########
File path:
server/protocols/protocols-imap4/src/test/java/org/apache/james/imapserver/netty/ImapRequestFrameDecoderTest.java
##########
@@ -46,35 +37,35 @@ void setUp() {
18);
}
- @Test
- void newCumulationBufferShouldNotThrowWhenNoAttachments() {
- ChannelHandlerContext channelHandler =
mock(ChannelHandlerContext.class);
- Channel channel = mock(Channel.class);
- ChannelConfig channelConfig = mock(ChannelConfig.class);
+// @Test
+// void newCumulationBufferShouldNotThrowWhenNoAttachments() {
+// ChannelHandlerContext channelHandler =
mock(ChannelHandlerContext.class);
+// Channel channel = mock(Channel.class);
+// ChannelConfig channelConfig = mock(ChannelConfig.class);
+//
+// //
when(channelConfig.getBufferFactory()).thenReturn(mock(ChannelBufferFactory.class));
+// when(channelHandler.channel()).thenReturn(channel);
+// when(channel.config()).thenReturn(channelConfig);
+//
+//
when(channelHandler.getAttachment()).thenReturn(ImmutableMap.<String,
Object>of());
+//
+// assertThatCode(() -> testee.newCumulationBuffer(channelHandler, 36))
+// .doesNotThrowAnyException();
+// }
-
when(channelConfig.getBufferFactory()).thenReturn(mock(ChannelBufferFactory.class));
- when(channelHandler.getChannel()).thenReturn(channel);
- when(channel.getConfig()).thenReturn(channelConfig);
-
- when(channelHandler.getAttachment()).thenReturn(ImmutableMap.<String,
Object>of());
-
- assertThatCode(() -> testee.newCumulationBuffer(channelHandler, 36))
- .doesNotThrowAnyException();
- }
-
- @Test
- void newCumulationBufferShouldNotThrowOnNegativeSize() {
- ChannelHandlerContext channelHandler =
mock(ChannelHandlerContext.class);
- Channel channel = mock(Channel.class);
- ChannelConfig channelConfig = mock(ChannelConfig.class);
-
-
when(channelConfig.getBufferFactory()).thenReturn(mock(ChannelBufferFactory.class));
- when(channelHandler.getChannel()).thenReturn(channel);
- when(channel.getConfig()).thenReturn(channelConfig);
-
- when(channelHandler.getAttachment()).thenReturn(ImmutableMap.<String,
Object>of(NEEDED_DATA, -1));
-
- assertThatCode(() -> testee.newCumulationBuffer(channelHandler, 36))
- .doesNotThrowAnyException();
- }
+// @Test
+// void newCumulationBufferShouldNotThrowOnNegativeSize() {
+// ChannelHandlerContext channelHandler =
mock(ChannelHandlerContext.class);
+// Channel channel = mock(Channel.class);
+// ChannelConfig channelConfig = mock(ChannelConfig.class);
+//
+//
when(channelConfig.getBufferFactory()).thenReturn(mock(ChannelBufferFactory.class));
+// when(channelHandler.getChannel()).thenReturn(channel);
+// when(channel.getConfig()).thenReturn(channelConfig);
+//
+//
when(channelHandler.getAttachment()).thenReturn(ImmutableMap.<String,
Object>of(NEEDED_DATA, -1));
+//
+// assertThatCode(() -> testee.newCumulationBuffer(channelHandler, 36))
+// .doesNotThrowAnyException();
+// }
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
