ff-wl commented on a change in pull request #886:
URL: https://github.com/apache/james-project/pull/886#discussion_r808758639
##########
File path:
server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/NettyImapRequestLineReader.java
##########
@@ -105,8 +106,8 @@ public Literal read(int size, boolean extraCRLF) throws
DecodingException {
try {
- // limit the size via commons-io as ChannelBufferInputStream size
limiting is buggy
- InputStream in = new BoundedInputStream(new
ChannelBufferInputStream(buffer), size);
+ // limit the size via commons-io as ByteBufInputStream size
limiting is buggy
Review comment:
The code for old ChannelBufferInputStream and new ByteBufInputStream are
quite similar, so I expect the same behaviour. Is there a test case that would
trigger the bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]