chibenwa commented on a change in pull request #911:
URL: https://github.com/apache/james-project/pull/911#discussion_r822697791
##########
File path:
server/container/lifecycle-api/src/main/java/org/apache/james/lifecycle/api/Disposable.java
##########
@@ -29,4 +39,111 @@
* Dispose the object
*/
void dispose();
+
+ abstract class LeakAware implements Disposable {
+ public static class LeakDetectorException extends RuntimeException {
+ public LeakDetectorException() {
+ super();
+ }
+
+ public LeakDetectorException(String message) {
+ super(message);
+ }
+
+ public LeakDetectorException(String message, Throwable cause) {
+ super(message, cause);
+ }
+ }
+
+ public enum Level {
+ NONE,
+ SIMPLE,
+ ADVANCED,
+ TESTING;
+
+ static Level parse(String input) {
+ for (Level level : values()) {
+ if (level.name().equalsIgnoreCase(input)) {
+ return level;
+ }
+ }
+ throw new IllegalArgumentException(String.format("Unknown
level `%s`", input));
+ }
+ }
+
+ public static final ReferenceQueue<Object> REFERENCE_QUEUE = new
ReferenceQueue<>();
+ public static final List<LeakAwareFinalizer> LEAK_REFERENCES = new
ArrayList<>();
+ public static Level level;
+ private final AtomicBoolean isDisposed;
+
+ protected LeakAware() {
+ isDisposed = new AtomicBoolean(false);
+ level = Level.SIMPLE; // todo
+ LEAK_REFERENCES.add(new LeakAwareFinalizer(this, REFERENCE_QUEUE));
+ }
+
+ public void disposed() {
+ isDisposed.set(true);
+ }
+
+ public static void track() {
+ if (leakDetectorEnabled()) {
+ Reference<?> referenceFromQueue;
+ while ((referenceFromQueue = REFERENCE_QUEUE.poll()) != null) {
+ ((LeakAwareFinalizer) referenceFromQueue).detectLeak();
+ referenceFromQueue.clear();
+ }
+ }
+ }
+
+ private static boolean leakDetectorEnabled() {
+ return level != Level.NONE;
+ }
+ }
+
+ class LeakAwareFinalizer extends PhantomReference<Object> {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(LeakAwareFinalizer.class);
+
+ private LeakAware referent;
+
+ public LeakAwareFinalizer(LeakAware referent, ReferenceQueue<? super
Object> q) {
+ super(referent, q);
+// this.referent = referent;
Review comment:
The cleanup needs to be a callback to the reference cf
https://dzone.com/articles/weak-soft-and-phantom-references-in-java-and-why-they-matter
Since Phantom doesn't have a link to the actual object, a typical pattern is
to derive your own Reference type from Phantom and add some info useful for the
final freeing, for example filename.
LeakAware likely need to provide a callback to clean its guts, of course
without referencing itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
