woj-tek commented on PR #1476: URL: https://github.com/apache/james-project/pull/1476#issuecomment-1473982971
> Unfortunately I think it is... I ran that test on master branch -> success every time I ran that test on your branch -> fails every time... > > I tried to take a quick look at why it fails but I'm at a bit of a loss honestly. But it is related to the PR, I'm sorry. It's caused by this change https://github.com/apache/james-project/pull/1476/files#diff-1d7aee20797c7e30c6d737b31a644a146bb6e68bcd6ddbd599dd518dcf3da335R83 and then I made same changes in the problematic test: https://github.com/apache/james-project/pull/1476/files#diff-af9e56bd418cc71a19d530bb8b3d40b8d78f478dcbfaf6ec9355643fcfb466e5R65. Most likely doing setting IMAP configuration in `JamesImapHostSystem` affects other IMAP processors hence difference in actual and expected list of capabilities. Will have to look more thoroughly into it. > Between `assertThatJson` and `isEqualTo` you can add the method `.withOptions(new Options(IGNORING_ARRAY_ORDER))`. It will ignore the order of the list (we didn't clean up everything related to that thanks for spotting it) Thanks! That did the trick :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
