woj-tek commented on PR #1476: URL: https://github.com/apache/james-project/pull/1476#issuecomment-1474201916
> > 1. `org.apache.james.mpt.imapmailbox.suite.Condstore#condstoreShouldBeEnableWhenGivenAndTrue` - this one seems to be unrelated to default mailboxes > > Unfortunately I think it is... I ran that test on master branch -> success every time I ran that test on your branch -> fails every time... I dug a bit more into it, and it seems it was caused by https://issues.apache.org/jira/browse/JAMES-2055 & https://github.com/linagora/james-project/pull/841/files and my change in testing when I used default global configuration but `Condstore` test was changing configuration as well (to check if disabling it works correctly). The issue was that if it got disabled once (as I did globally), it wasn't possible to re-enable it (which the `Condstore` was doing) hence the failing test. I'm not sure if reconfiguration is possible / expected, but I modified `CapabilityProcessor` so it's possible to disable/enable it on subsequent `configure()` calls and added unit test to verify it's working correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
