chibenwa commented on code in PR #1643:
URL: https://github.com/apache/james-project/pull/1643#discussion_r1260533417
##########
server/data/data-jmap/src/main/java/org/apache/james/jmap/api/filtering/Rule.java:
##########
@@ -344,15 +350,22 @@ public static Builder builder() {
return new Builder();
}
+ public enum ConditionCombiner {
+ AND,
+ OR
+ }
+
private final Id id;
private final String name;
- private final Condition condition;
+ private final List<Condition> conditions;
+ private final ConditionCombiner conditionCombiner;
private final Action action;
- private Rule(Id id, String name, Condition condition, Action action) {
+ private Rule(Id id, String name, List<Condition> conditions,
ConditionCombiner conditionCombiner, Action action) {
Review Comment:
I would wrap conditions and combiner into its own distinct POJO:
```
class Conditions {
ConditionCombiner conditionCombiner;
List<Condition> conditions;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
