chibenwa commented on code in PR #1643:
URL: https://github.com/apache/james-project/pull/1643#discussion_r1261428283
##########
server/data/data-jmap-cassandra/src/main/java/org/apache/james/jmap/cassandra/filtering/RuleDTO.java:
##########
@@ -217,30 +254,27 @@ public static ImmutableList<RuleDTO> from(List<Rule>
rules) {
public static RuleDTO from(Rule rule) {
return new RuleDTO(rule.getId().asString(),
rule.getName(),
-
rule.getConditions().stream().map(ConditionDTO::from).collect(Collectors.toList()),
- rule.getConditionCombiner(),
+ ConditionGroupDTO.from(rule.getConditionGroup()),
ActionDTO.from(rule.getAction()));
}
private final String id;
private final String name;
private final ConditionDTO conditionDTO;
- private final List<ConditionDTO> conditionDTOs;
- private final Rule.ConditionCombiner conditionCombiner;
+ private final ConditionGroupDTO conditionGroupDTO;
private final ActionDTO actionDTO;
@JsonCreator
public RuleDTO(@JsonProperty("id") String id,
@JsonProperty("name") String name,
- @JsonProperty("conditions") List<ConditionDTO>
conditionDTOs,
- @JsonProperty("conditionCombiner") Rule.ConditionCombiner
conditionCombiner,
+ @JsonProperty("conditionGroup") ConditionGroupDTO
conditionGroupDTO,
Review Comment:
I do not think this preserved retro-compatibility...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
