chibenwa commented on code in PR #1643:
URL: https://github.com/apache/james-project/pull/1643#discussion_r1261433307
##########
server/data/data-jmap-cassandra/src/main/java/org/apache/james/jmap/cassandra/filtering/RuleDTO.java:
##########
@@ -249,15 +283,18 @@ public RuleDTO(@JsonProperty("id") String id,
public RuleDTO(@JsonProperty("id") String id,
@JsonProperty("name") String name,
@JsonProperty("condition") ConditionDTO conditionDTO,
- @JsonProperty("conditions") List<ConditionDTO>
conditionDTOs,
- @JsonProperty("conditionCombiner") Rule.ConditionCombiner
conditionCombiner,
+ @JsonProperty("conditionGroup") ConditionGroupDTO
conditionGroupDTO,
@JsonProperty("action") ActionDTO actionDTO) {
+ Preconditions.checkNotNull(id);
+
this.name = name;
this.conditionDTO = conditionDTO;
- this.conditionDTOs = conditionDTOs;
- this.conditionCombiner = conditionCombiner;
+ if (conditionGroupDTO != null) {
Review Comment:
Ban null. Use optionals instead.
Register jackson JDK 8 module if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
