quantranhong1999 commented on code in PR #1651:
URL: https://github.com/apache/james-project/pull/1651#discussion_r1297023616
##########
server/apps/distributed-app/docker-compose-with-pulsar.yml:
##########
@@ -0,0 +1,97 @@
+version: '3'
+
+services:
+
+ james:
+ depends_on:
+ cassandra:
+ condition: service_healthy
+ opensearch:
+ condition: service_started
+ tika:
+ condition: service_started
+ rabbitmq:
+ condition: service_started
+ s3:
+ condition: service_started
+ pulsar:
+ condition: service_started
+ image: apache/james:distributed-latest
+ container_name: james
+ hostname: james.local
+ command:
+ - --generate-keystore
+ networks:
+ - james
+ ports:
+ - "80:80"
+ - "25:25"
+ - "110:110"
+ - "143:143"
+ - "465:465"
+ - "587:587"
+ - "993:993"
+ - "8000:8000"
+ volumes:
+ - ./sample-configuration/pulsar.properties:/root/conf/pulsar.properties
+ - ./sample-configuration/keystore:/root/conf/keystore
+
+ opensearch:
+ image: opensearchproject/opensearch:2.1.0
+ environment:
+ - discovery.type=single-node
+ - DISABLE_INSTALL_DEMO_CONFIG=true
+ - DISABLE_SECURITY_PLUGIN=true
+ networks:
+ james:
+ aliases:
+ - elasticsearch
Review Comment:
```suggestion
- opensearch
```
##########
server/apps/distributed-app/docker-compose.yml:
##########
@@ -32,37 +37,47 @@ services:
- discovery.type=single-node
- DISABLE_INSTALL_DEMO_CONFIG=true
- DISABLE_SECURITY_PLUGIN=true
+ networks:
+ james:
+ aliases:
+ - elasticsearch
cassandra:
- image: cassandra:3.11.10
+ image: cassandra:4.1.3
Review Comment:
These changes should be on the origin master already. Let's rebase on the
latest origin master to avoid "staying with the past code".
##########
server/apps/distributed-app/docker-compose-with-pulsar.yml:
##########
@@ -0,0 +1,97 @@
+version: '3'
+
+services:
+
+ james:
+ depends_on:
+ cassandra:
+ condition: service_healthy
+ opensearch:
+ condition: service_started
+ tika:
+ condition: service_started
+ rabbitmq:
+ condition: service_started
+ s3:
+ condition: service_started
+ pulsar:
+ condition: service_started
+ image: apache/james:distributed-latest
+ container_name: james
+ hostname: james.local
+ command:
+ - --generate-keystore
+ networks:
+ - james
+ ports:
+ - "80:80"
+ - "25:25"
+ - "110:110"
+ - "143:143"
+ - "465:465"
+ - "587:587"
+ - "993:993"
+ - "8000:8000"
+ volumes:
+ - ./sample-configuration/pulsar.properties:/root/conf/pulsar.properties
+ - ./sample-configuration/keystore:/root/conf/keystore
+
+ opensearch:
+ image: opensearchproject/opensearch:2.1.0
+ environment:
+ - discovery.type=single-node
+ - DISABLE_INSTALL_DEMO_CONFIG=true
+ - DISABLE_SECURITY_PLUGIN=true
+ networks:
+ james:
+ aliases:
+ - elasticsearch
+
+ cassandra:
+ image: cassandra:4.1.3
+ ports:
+ - "9042:9042"
+ healthcheck:
+ test: [ "CMD", "cqlsh", "-e", "describe keyspaces" ]
+ interval: 3s
+ timeout: 20s
+ retries: 5
+ networks:
+ - james
+
+ tika:
+ image: apache/tika:2.8.0.0
+ networks:
+ - james
+
+ rabbitmq:
+ image: rabbitmq:3.12.1-management
+ ports:
+ - "5672:5672"
+ - "15672:15672"
+ networks:
+ - james
+
+ s3:
+ image: registry.scality.com/cloudserver/cloudserver:8.7.25
+ container_name: s3.docker.test
+ environment:
+ - SCALITY_ACCESS_KEY_ID=accessKey1
+ - SCALITY_SECRET_ACCESS_KEY=secretKey1
+ - S3BACKEND=mem
+ - LOG_LEVEL=trace
+ - REMOTE_MANAGEMENT_DISABLE=1
+ networks:
+ - james
+ pulsar:
+ image: apachepulsar/pulsar:2.10.1
+ container_name: pulsar
+ command: >
+ bin/pulsar standalone
+ ports:
+ - "8080:8080"
+ - "6650:6650"
+ networks:
+ - james
+networks:
+ james:
Review Comment:
All the containers in the same docker-compose would be bound to the same
docker-compose network created by Docker automatically. Each container would
have its container name e.g `pulsar`, or even its service name as a network
alias.
So no need to explicitly declare a network and container alias in that
network IMO.
But this was good for practice though :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
