quantranhong1999 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1302842413
########## server/apps/distributed-app/src/test/java/org/apache/james/CassandraPulsarJamesServerTest.java: ########## @@ -0,0 +1,46 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james; + +import org.apache.james.jmap.draft.JmapJamesServerContract; +import org.apache.james.modules.TestJMAPServerModule; +import org.apache.james.modules.blobstore.BlobStoreConfiguration; +import org.junit.jupiter.api.extension.RegisterExtension; + +public class CassandraPulsarJamesServerTest implements JmapJamesServerContract, JamesServerConcreteContract{ Review Comment: ```suggestion public class CassandraPulsarJamesServerTest implements JmapJamesServerContract, JamesServerConcreteContract { ``` ########## backends-common/rabbitmq/src/main/java/org/apache/james/backends/rabbitmq/RabbitMQConfiguration.java: ########## @@ -682,6 +684,7 @@ private static Optional<SSLKeyStore> getSSLKeyStore(Configuration configuration) private final boolean eventBusNotificationDurabilityEnabled; private final Optional<String> vhost; + @Inject Review Comment: Why do we need @Inject here? ########## server/apps/distributed-app/docker-compose-with-pulsar.yml: ########## @@ -3,19 +3,6 @@ version: '3' services: james: - depends_on: - cassandra: - condition: service_healthy - opensearch: - condition: service_started - tika: - condition: service_started - rabbitmq: - condition: service_started - s3: - condition: service_started - pulsar: - condition: service_started Review Comment: Why remove this? It is good to keep, no? ########## server/apps/distributed-app/docker-compose-with-pulsar.yml: ########## @@ -34,10 +21,11 @@ services: - "8000:8000" volumes: - ./sample-configuration/pulsar.properties:/root/conf/pulsar.properties - - ./sample-configuration/keystore:/root/conf/keystore + - ./sample-configuration/queue.properties:/root/conf/queue.properties Review Comment: Did you retest the Pulsar docker-compose with this change? The current sample `queue.properties` file comes with `queue.choice=RABBITMQ`, therefore I really doubt if the Pulsar mail queue is actually being used here. ```suggestion - ./sample-configuration/queue-pulsar.properties:/root/conf/queue.properties ``` ########## server/apps/distributed-app/docs/modules/ROOT/pages/configure/queue.adoc: ########## @@ -0,0 +1,19 @@ += Distributed James Server — queue.properties +:navtitle: queue.properties + +This configuration helps you configure mail queue you want to select. + +== Queue Configuration + +.queue.properties content +|=== +| Property name | explanation + +| queue.choice +| Mail queue can be implemented by many different type of message brokers: Pulsar, RabbitMQ,.... This property will choose which mail queue you want, defaulting to RABBITMQ +|=== + +`queue.choice` supports the following options: Review Comment: Rethink about the property name, I think maybe the name e.g. `mail.queue.choice` would be more clear. Because we have other queues e.g. event queue and task queue, the current property seems easy to misunderstand. I would tend to understand all queue types would be solely using Pulsar for example. ########## backends-common/rabbitmq/src/main/java/org/apache/james/backends/rabbitmq/ReactorRabbitMQChannelPool.java: ########## @@ -663,6 +664,7 @@ public int getMaxChannel() { private final MetricFactory metricFactory; private Sender sender; + @Inject Review Comment: Why do we need @Inject here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
