quantranhong1999 commented on code in PR #1651:
URL: https://github.com/apache/james-project/pull/1651#discussion_r1305089915
##########
server/apps/distributed-app/src/main/java/org/apache/james/CassandraRabbitMQJamesServerMain.java:
##########
@@ -205,6 +206,21 @@ public static GuiceJamesServer
createServer(CassandraRabbitMQJamesConfiguration
.combineWith(chooseJmapModule(configuration));
}
+ private static Module chooseMailQueue(CassandraRabbitMQJamesConfiguration
configuration) {
+ switch (configuration.getMailQueueChoice()) {
+ case PULSAR:
+ return new PulsarQueueModule();
+ case RABBITMQ:
+ return Modules.combine(
+ new RabbitMQModule(),
+ new RabbitMailQueueRoutesModule(),
+ new RabbitMQMailQueueModule(),
+
MailQueueViewChoice.ModuleChooser.choose(configuration.getMailQueueViewChoice()));
Review Comment:
> Is it normal to have the helath check for rabbitmq injkected for pulsar
for example?
Currently, task queue and event still rely on RabbitMQ, what is wrong with
still having RabbitMQHealthCheck?
Reminding you that we are migrating `RabbitMQ alone` -> `RabbitMQ + Pulsar
mixed` -> `Pulsar alone`. We did not have the resources to fully migrate to
Pulsar in 1 shot.
And on the mail queue module separation, @chibenwa did a pair with Thanh
btw...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
