quantranhong1999 commented on code in PR #1651:
URL: https://github.com/apache/james-project/pull/1651#discussion_r1304079067


##########
server/apps/distributed-app/src/main/java/org/apache/james/CassandraRabbitMQJamesServerMain.java:
##########
@@ -205,6 +206,21 @@ public static GuiceJamesServer 
createServer(CassandraRabbitMQJamesConfiguration
             .combineWith(chooseJmapModule(configuration));
     }
 
+    private static Module chooseMailQueue(CassandraRabbitMQJamesConfiguration 
configuration) {
+        switch (configuration.getMailQueueChoice()) {
+            case PULSAR:
+                return new PulsarQueueModule();
+            case RABBITMQ:
+                return Modules.combine(
+                    new RabbitMQModule(),
+                    new RabbitMailQueueRoutesModule(),
+                    new RabbitMQMailQueueModule(),
+                    
MailQueueViewChoice.ModuleChooser.choose(configuration.getMailQueueViewChoice()));

Review Comment:
   Well `RabbitMQModule` should not be in here actually @Arsnael 
   Please check again @thanhbv200585 



##########
server/apps/distributed-app/src/main/java/org/apache/james/CassandraRabbitMQJamesServerMain.java:
##########
@@ -205,6 +206,21 @@ public static GuiceJamesServer 
createServer(CassandraRabbitMQJamesConfiguration
             .combineWith(chooseJmapModule(configuration));
     }
 
+    private static Module chooseMailQueue(CassandraRabbitMQJamesConfiguration 
configuration) {
+        switch (configuration.getMailQueueChoice()) {
+            case PULSAR:
+                return new PulsarQueueModule();
+            case RABBITMQ:
+                return Modules.combine(
+                    new RabbitMQModule(),
+                    new RabbitMailQueueRoutesModule(),
+                    new RabbitMQMailQueueModule(),
+                    
MailQueueViewChoice.ModuleChooser.choose(configuration.getMailQueueViewChoice()));

Review Comment:
   Well `RabbitMQModule` should not be in here actually @Arsnael 
   Please check again @thanhbv200585 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to