chibenwa commented on code in PR #1824:
URL: https://github.com/apache/james-project/pull/1824#discussion_r1413425402
##########
server/protocols/protocols-imap4/src/test/java/org/apache/james/imapserver/netty/IMAPServerTest.java:
##########
@@ -265,6 +206,63 @@ private IMAPServer createImapServer(String
configurationFile) throws Exception {
@Nested
class ConnectionCheckTest {
+ private IMAPServer
createImapServer(HierarchicalConfiguration<ImmutableNode> config,
Review Comment:
Can we avoid yet another (massive) code duplication?
Can we think of a little refactoring in order to share IMAP server
initialization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
