chibenwa commented on code in PR #1824:
URL: https://github.com/apache/james-project/pull/1824#discussion_r1420089726
##########
third-party/crowdsec/src/main/java/org/apache/james/module/CrowdsecModule.java:
##########
@@ -36,6 +37,7 @@ public class CrowdsecModule extends AbstractModule {
@Override
protected void configure() {
Multibinder.newSetBinder(binder(), CrowdsecImapConnectionCheck.class);
+ bind(ConnectionCheck.class).to(CrowdsecImapConnectionCheck.class);
Review Comment:
> Should be Multibinder.newSetBinder(binder(),
ConnectionCheck.class).addBinding().to(CrowdsecImapConnectionCheck);
Yes
> BTW we guided Guice to load CrowdsecImapConnectionCheck via
additionalConnectionChecks extension mechanism already
Ok thus completly uneeded
> additionalConnectionChecks extension mechanism
Is `additionalConnectionChecks` documented?
Is setting up Crowdsec extensions with `additionalConnectionChecks`
documented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
