vttranlina commented on PR #2362: URL: https://github.com/apache/james-project/pull/2362#issuecomment-2249228793
Note: my manual test: - :white_check_mark: I tested the case of running docker-compose up, then shut down the redis-master node. The failover of the sentinel and replica nodes was completed successfully. During the failover process, the log from James: ``` 2024-07-24T19:23:26.149474096Z 19:23:26.149 [INFO ] o.a.j.w.m.LoggingRequestFilter - WebAdmin request received 2024-07-24T19:23:27.940731528Z 19:23:27.940 [WARN ] o.a.j.w.r.HealthCheckRoutes - HealthCheck is unstable for Redis : Can not connect to Redis. 2024-07-24T19:23:27.941470385Z 19:23:27.941 [INFO ] o.a.j.w.m.LoggingResponseFilter - WebAdmin response received 2024-07-24T19:23:28.137933072Z 19:23:28.137 [WARN ] o.a.j.w.r.HealthCheckRoutes - HealthCheck is unstable for Redis : Can not connect to Redis. 2024-07-24T19:23:28.138330538Z 19:23:28.138 [INFO ] o.a.j.w.m.LoggingResponseFilter - WebAdmin response received 2024-07-24T19:23:28.334451052Z 19:23:28.334 [WARN ] o.a.j.w.r.HealthCheckRoutes - HealthCheck is unstable for Redis : Can not connect to Redis. 2024-07-24T19:23:28.334743380Z 19:23:28.334 [INFO ] o.a.j.w.m.LoggingResponseFilter - WebAdmin response received 2024-07-24T19:23:28.539857676Z 19:23:28.539 [WARN ] o.a.j.w.r.HealthCheckRoutes - HealthCheck is unstable for Redis : Can not connect to Redis. 2024-07-24T19:23:28.540234393Z 19:23:28.540 [INFO ] o.a.j.w.m.LoggingResponseFilter - WebAdmin response received 2024-07-24T19:23:28.743990148Z 19:23:28.743 [WARN ] o.a.j.w.r.HealthCheckRoutes - HealthCheck is unstable for Redis : Can not connect to Redis. 2024-07-24T19:23:28.744325638Z 19:23:28.744 [INFO ] o.a.j.w.m.LoggingResponseFilter - WebAdmin response received 2024-07-24T19:23:28.932333544Z 19:23:28.932 [WARN ] o.a.j.w.r.HealthCheckRoutes - HealthCheck is unstable for Redis : Can not connect to Redis. 2024-07-24T19:23:28.932631133Z 19:23:28.932 [INFO ] o.a.j.w.m.LoggingResponseFilter - WebAdmin response received 2024-07-24T19:23:29.150144421Z 19:23:29.150 [WARN ] o.a.j.w.r.HealthCheckRoutes - HealthCheck is unstable for Redis : Can not connect to Redis. 2024-07-24T19:23:29.150510257Z 19:23:29.150 [INFO ] o.a.j.w.m.LoggingResponseFilter - WebAdmin response received 2024-07-24T19:23:34.551245574Z 19:23:34.550 [WARN ] i.l.c.p.ConnectionWatchdog - Cannot reconnect to [172.19.0.2/<unresolved>:6379]: java.nio.channels.ClosedChannelException 2024-07-24T19:23:34.551261975Z java.nio.channels.ClosedChannelException: null 2024-07-24T19:23:34.551265471Z at io.netty.channel.epoll.AbstractEpollChannel.doClose(AbstractEpollChannel.java:159) 2024-07-24T19:23:34.551268547Z at io.netty.channel.epoll.AbstractEpollStreamChannel.doClose(AbstractEpollStreamChannel.java:673) 2024-07-24T19:23:34.551271402Z at io.netty.channel.AbstractChannel$AbstractUnsafe.doClose0(AbstractChannel.java:752) 2024-07-24T19:23:34.551274338Z at io.netty.channel.AbstractChannel$AbstractUnsafe.close(AbstractChannel.java:729) 2024-07-24T19:23:34.551277283Z at io.netty.channel.AbstractChannel$AbstractUnsafe.close(AbstractChannel.java:619) 2024-07-24T19:23:34.551280279Z at io.netty.channel.DefaultChannelPipeline$HeadContext.close(DefaultChannelPipeline.java:1349) 2024-07-24T19:23:34.551282974Z at io.netty.channel.AbstractChannelHandlerContext.invokeClose(AbstractChannelHandlerContext.java:755) 2024-07-24T19:23:34.551285830Z at io.netty.channel.AbstractChannelHandlerContext.access$1200(AbstractChannelHandlerContext.java:61) 2024-07-24T19:23:34.551288785Z at io.netty.channel.AbstractChannelHandlerContext$11.run(AbstractChannelHandlerContext.java:738) 2024-07-24T19:23:34.551291230Z at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173) 2024-07-24T19:23:34.551293734Z at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166) 2024-07-24T19:23:34.551296279Z at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469) 2024-07-24T19:23:34.551299014Z at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:405) 2024-07-24T19:23:34.551301659Z at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:994) 2024-07-24T19:23:34.551309604Z at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) 2024-07-24T19:23:34.551314573Z at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) 2024-07-24T19:23:34.551324562Z at java.base/java.lang.Thread.run(Unknown Source) 2024-07-24T19:23:56.332209814Z 19:23:56.332 [INFO ] o.a.j.w.m.LoggingRequestFilter - WebAdmin request received ``` The health check degrades for a few seconds before recovering to a healthy state => confirming it works as expected. Regarding the rate limiter integration test, I have already pushed the commit.[org.apache.james.rate.limiter.RedisRateLimiterWithSentinelTest#rateLimitShouldWorkNormallyAfterFailoverComplete](https://github.com/apache/james-project/pull/2358/commits/b130942fd4a7f2b4fe28b326955dc459e4d949a1) in pr https://github.com/apache/james-project/pull/2358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
