hungphan227 commented on code in PR #2362:
URL: https://github.com/apache/james-project/pull/2362#discussion_r1690734521
##########
backends-common/redis/src/main/java/org/apache/james/backends/redis/RedisConfiguration.scala:
##########
@@ -104,11 +105,17 @@ case class StandaloneRedisConfiguration(redisURI:
RedisURI, ioThreads: Option[In
}
object MasterReplicaRedisConfiguration {
- def from(config: Configuration): MasterReplicaRedisConfiguration =
- from(config.getStringArray("redisURL"),
+ def from(config: Configuration): MasterReplicaRedisConfiguration = {
+ val redisUris: Array[String] = config.getString(REDIS_URL_PROPERTY_NAME)
match {
+ case rawValue if rawValue.startsWith("redis-sentinel:") =>
Array(config.getStringArray(REDIS_URL_PROPERTY_NAME).mkString(","))
Review Comment:
`config.getStringArray(REDIS_URL_PROPERTY_NAME).mkString(",")`
Why not simple config.getString(REDIS_URL_PROPERTY_NAME) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]