chibenwa commented on code in PR #2418:
URL: https://github.com/apache/james-project/pull/2418#discussion_r1771115037
##########
server/mailet/rate-limiter-redis/src/main/scala/org/apache/james/rate/limiter/redis/RedisRateLimiter.scala:
##########
@@ -67,6 +68,31 @@ class RedisRateLimiterFactory @Inject()(redisConfiguration:
RedisConfiguration)
masterReplicaRedisConfiguration.redisURI.value.asJava,
masterReplicaRedisConfiguration.readFrom)
+ case sentinelRedisConfiguration: SentinelRedisConfiguration => new
RedisSingleInstanceRateLimitjFactory(RedisClient.create(sentinelRedisConfiguration.redisURI))
+
+ case tlsStandaloneRedisConfiguration: TLSStandaloneRedisConfiguration =>
Review Comment:
The complexity of injecting the redis client is leaking into the call sites.
Is this intended?
Shouldn't this place just be injected the RedisClient? Why is it
instanciating it itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
