Arsnael commented on code in PR #2418:
URL: https://github.com/apache/james-project/pull/2418#discussion_r1772806703


##########
backends-common/redis/src/main/java/org/apache/james/backends/redis/RedisConfiguration.scala:
##########
@@ -158,4 +177,114 @@ case class ClusterRedisConfiguration(redisURI: RedisUris, 
ioThreads: Option[Int]
     .add("redis.ioThreads", ioThreads)
     .add("redis.workerThreads", workerThreads)
     .toString
+}
+
+object SentinelRedisConfiguration {

Review Comment:
   It would make more sense to split this work into two PRs:
   - Sentinel redis configuration
   - Redis SSL
   
   Actually the redis sentinel configuration should be an all other ticket



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org

Reply via email to