chibenwa commented on code in PR #2421: URL: https://github.com/apache/james-project/pull/2421#discussion_r1777523692
########## mailbox/api/src/main/java/org/apache/james/mailbox/model/MailboxACL.java: ########## @@ -383,6 +383,11 @@ public static EntryKey createUserEntryKey(Username name, boolean negative) { return new EntryKey(name.asString(), NameType.user, negative); } + public static EntryKey createUserOrSpecialEntryKey(Username name) { Review Comment: `or` in a method name? What to expect? Sorry, reflex. Naming should be improved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org