chibenwa commented on code in PR #2421:
URL: https://github.com/apache/james-project/pull/2421#discussion_r1777533856
##########
protocols/imap/src/main/java/org/apache/james/imap/message/request/SetACLRequest.java:
##########
@@ -19,35 +19,59 @@
package org.apache.james.imap.message.request;
+import org.apache.james.core.Username;
import org.apache.james.imap.api.ImapConstants;
import org.apache.james.imap.api.Tag;
+import org.apache.james.mailbox.model.MailboxACL;
import com.google.common.base.MoreObjects;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
/**
* SETACL Request.
*/
public class SetACLRequest extends AbstractImapRequest {
- private final String identifier;
- private final String mailboxName;
- private final String rights;
+ private final Username identifier;
+ private final MailboxACL.EditMode editMode;
+ private final MailboxACL.Rfc4314Rights rights;
- public SetACLRequest(Tag tag, String mailboxName, String identifier,
String rights) {
+ public static class MailboxName {
+ private final String mailboxName;
+
+ public MailboxName(String mailboxName) {
+ Preconditions.checkArgument(!Strings.isNullOrEmpty(mailboxName),
"MailboxName must not be null or empty");
+ this.mailboxName = mailboxName;
+ }
+
+ public String asString() {
+ return mailboxName;
+ }
+ }
+
+ private final MailboxName mailboxName;
Review Comment:
Group this with other fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
