chibenwa commented on code in PR #2465:
URL: https://github.com/apache/james-project/pull/2465#discussion_r1810620608


##########
event-bus/api/src/main/java/org/apache/james/events/EventDeadLetters.java:
##########
@@ -93,6 +94,10 @@ public String asString() {
 
     Mono<Event> failedEvent(Group registeredGroup, InsertionId 
failDeliveredInsertionId);
 
+    default Mono<Event> failedEvent(Group registeredGroup, InsertionId 
failDeliveredInsertionId, Map<Group, EventSerializer> 
mapGroupToEventSerializer) {

Review Comment:
   Bad answer.
   
   Then we 'just need one more level of indirection...
   
   How about a `EventBusses` interface that would abstract this away tfor us?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org

Reply via email to