chibenwa commented on code in PR #2465:
URL: https://github.com/apache/james-project/pull/2465#discussion_r1813356540
##########
event-bus/cassandra/src/main/java/org/apache/james/events/CassandraEventDeadLetters.java:
##########
@@ -19,23 +19,44 @@
package org.apache.james.events;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+
import jakarta.inject.Inject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableSet;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
public class CassandraEventDeadLetters implements EventDeadLetters {
Review Comment:
Are we really going to duplicate the Event -> Json and json -> event in all
classes like PG or we do plan to have an abstraction we can reuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
