(james-project) 01/02: JAMES-3754 Update IMAP4 ID - return NIL, replace to empty list

[rcordier]

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 74cea3952d70144273bae5525093ff6e095cb867
Author: TungTV <vtt...@linagora.com>
AuthorDate: Thu Oct 31 09:28:54 2024 +0700

    JAMES-3754 Update IMAP4 ID - return NIL, replace to empty list
    
    The rfc2971 write that:
    A server MUST send a tagged ID response to an ID command.
    However, a server MAY send NIL in place of the list.
---
 .../core/src/main/resources/org/apache/james/imap/scripts/Id.test  | 7 +++----
 .../main/java/org/apache/james/imap/encode/IdResponseEncoder.java  | 4 ++--
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git 
a/mpt/impl/imap-mailbox/core/src/main/resources/org/apache/james/imap/scripts/Id.test
 
b/mpt/impl/imap-mailbox/core/src/main/resources/org/apache/james/imap/scripts/Id.test
index 51a613503b..7d91f3111e 100644
--- 
a/mpt/impl/imap-mailbox/core/src/main/resources/org/apache/james/imap/scripts/Id.test
+++ 
b/mpt/impl/imap-mailbox/core/src/main/resources/org/apache/james/imap/scripts/Id.test
@@ -18,14 +18,13 @@
 ################################################################
 
 C: a0 ID NIL
-S: \* ID \(\)
+S: \* ID NIL
 S: a0 OK ID completed.
 
-
 C: a1 ID ("vendor", "whatever", "version", "3.7.0", "random", "random value")
-S: \* ID \(\)
+S: \* ID NIL
 S: a1 OK ID completed.
 
 C: a1 ID ("name" "Thunderbird" "version" "102.7.1")
-S: \* ID \(\)
+S: \* ID NIL
 S: a1 OK ID completed.
diff --git 
a/protocols/imap/src/main/java/org/apache/james/imap/encode/IdResponseEncoder.java
 
b/protocols/imap/src/main/java/org/apache/james/imap/encode/IdResponseEncoder.java
index 7c11c56c5a..fa7e7bfcef 100644
--- 
a/protocols/imap/src/main/java/org/apache/james/imap/encode/IdResponseEncoder.java
+++ 
b/protocols/imap/src/main/java/org/apache/james/imap/encode/IdResponseEncoder.java
@@ -20,6 +20,7 @@
 package org.apache.james.imap.encode;
 
 import java.io.IOException;
+import java.util.Map;
 
 import org.apache.james.imap.message.response.IdResponse;
 
@@ -33,8 +34,7 @@ public class IdResponseEncoder implements 
ImapResponseEncoder<IdResponse> {
     public void encode(IdResponse existsResponse, ImapResponseComposer 
composer) throws IOException {
         composer.untagged()
             .message("ID")
-            .openParen()
-            .closeParen()
+            .nil()
             .end();
     }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org