chibenwa commented on PR #2485:
URL: https://github.com/apache/james-project/pull/2485#issuecomment-2456933502
Hi @jeantil
> can you wait a bit before merging ?
of course ^^
> I am concerned about getDefaultBucket and how it is used.
I feel that this method is dangerous as it will never account for a tenant
making it easy to ignore tenancy at the callsite. if we want the blobstore and
james to be multitenant, the tenancy information should probably propagate
throughout all the call sites until we the point where we can determine the
information
Legitimate concerns indeed yet :
- the only component being currently multi-tenant is the mailbox
- and the only multi-tenant mailbox implementation is the PGSQL one.
The proposed changeset will then only make sense on top of that mailbox
> I am concerned about getDefaultBucket and how it is used.
We could easily say we kill that method, and make the notion of "default
bucket" a caller concern
(test constant, etc...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
