jeantil commented on code in PR #2485:
URL: https://github.com/apache/james-project/pull/2485#discussion_r1830006507
##########
server/blob/blob-api/src/main/java/org/apache/james/blob/api/BlobStoreDAO.java:
##########
@@ -128,9 +129,14 @@ default Publisher<Void> save(BucketName bucketName, BlobId
blobId, String data)
* @return a successful Publisher if the bucket is deleted or did not exist
* otherwise an IOObjectStoreException in its error channel
*/
- Publisher<Void> deleteBucket(BucketName bucketName);
+ Publisher<Void> deleteBucket(Bucket bucket);
Publisher<BucketName> listBuckets();
Review Comment:
this should return Buckets to be consistent wit the changed apis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
