Maxxx873 commented on code in PR #2489:
URL: https://github.com/apache/james-project/pull/2489#discussion_r1829941056
##########
server/mailet/mock-smtp-server/src/main/java/org/apache/james/mock/smtp/server/model/Mail.java:
##########
@@ -41,6 +41,9 @@
@JsonDeserialize(builder = Mail.Builder.class)
public class Mail {
+
+ public static final List<String> smtpParametersWithoutValues =
List.of("REQUIRETLS", "SMTPUTF8");
Review Comment:
Yes, we can get rid of the whitelist. But it seems to me that the mock
server operation would look more plausible if it only allowed certain
parameters without values. If we need to, we can decide how to pass the list as
arguments or properties or whatever. But if it really doesn't make sense, I'll
just leave it possible for any parameter to have an empty value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
