chibenwa commented on code in PR #2489: URL: https://github.com/apache/james-project/pull/2489#discussion_r1830281579
########## server/mailet/mock-smtp-server/src/main/java/org/apache/james/mock/smtp/server/model/Mail.java: ########## @@ -41,6 +41,9 @@ @JsonDeserialize(builder = Mail.Builder.class) public class Mail { + + public static final List<String> smtpParametersWithoutValues = List.of("REQUIRETLS", "SMTPUTF8"); Review Comment: My concern would be keep adding value and handling those two in a different fashion. If needed we could go from `Map<String, String>` as a datastructure to something like `Map<String, Optional<String>>`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org