chibenwa commented on code in PR #2491: URL: https://github.com/apache/james-project/pull/2491#discussion_r1831156830
########## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/Rights.scala: ########## @@ -104,15 +103,17 @@ object Rights { } .fold(EMPTY)(_ combine _) - private def toRights(entryKey: EntryKey, aclRights: Rfc4314Rights): Rights = of(Username.of(entryKey.getName), aclRights.toRights) + private def toRights(entryKey: EntryKey, aclRights: Rfc4314Rights): Rights = of(entryKey, aclRights.toRights) private def isSupported(key: EntryKey): Boolean = key match { Review Comment: While we are at it do we support negative entry key? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org