florentos17 commented on code in PR #2491:
URL: https://github.com/apache/james-project/pull/2491#discussion_r1831160706
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/Rights.scala:
##########
@@ -104,15 +103,17 @@ object Rights {
}
.fold(EMPTY)(_ combine _)
- private def toRights(entryKey: EntryKey, aclRights: Rfc4314Rights): Rights =
of(Username.of(entryKey.getName), aclRights.toRights)
+ private def toRights(entryKey: EntryKey, aclRights: Rfc4314Rights): Rights =
of(entryKey, aclRights.toRights)
private def isSupported(key: EntryKey): Boolean = key match {
Review Comment:
that's exactly what i was gonna ask next: using `EntryKey` instead of
`Username` is so that negative entry keys, group entry keys, etc are all de
facto supported now.
i suggest to write some tests about it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
