quantranhong1999 commented on code in PR #2495: URL: https://github.com/apache/james-project/pull/2495#discussion_r1841770445
########## docs/modules/servers/partials/configure/blobstore.adoc: ########## @@ -126,6 +126,29 @@ BucketPrefix is the prefix of bucket names in James BlobStore Unless a special case like storing blobs of deleted messages. |=== +==== SSE-C Configuration + +.SSE-C configuration +|=== +| Property name | explanation + +| encryption.s3.sse.c.enable +| optional: Boolean. Default is false. Controls whether to use Server-Side Encryption with Customer-Provided Keys (SSE-C) for S3 blobs. + +| encryption.s3.sse.c.master.key.algorithm +| String. Required if `encryption.s3.sse.c.enable` is true. The algorithm used to derive the master key from the provided password. Eg: AES256 + +| encryption.s3.sse.c.key.derivation.enabled +| optional: Boolean. Default is false. Controls whether to derive the encryption key from the bucket name as master key and blob-id as salt. + +| encryption.s3.sse.c.master.key.password +| String. Required if `encryption.s3.sse.c.key.derivation.enabled` is false. The password used to derive the customer key. Review Comment: This makes me confused. `Required if encryption.s3.sse.c.key.derivation.enabled is false` => `encryption.s3.sse.c.master.key.password` is needed when key derivation is **disabled**. Then reading the remaining part `The password used to derive the customer key` => why it is used to derive when derivation was disabled before? I think it was 2 different "derivations", no? Then we should rephrase a bit the `The password used to derive the customer key.` part IMO. ########## server/apps/distributed-app/src/test/java/org/apache/james/WithS3SSECTest.java: ########## @@ -0,0 +1,35 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james; + +import org.apache.james.blob.objectstorage.aws.sse.S3SSECConfiguration; +import org.apache.james.jmap.JmapJamesServerContract; +import org.apache.james.modules.S3SSECBlobStoreExtension; +import org.junit.jupiter.api.extension.RegisterExtension; + +public class WithS3SSECTest implements JmapJamesServerContract, JamesServerConcreteContract { Review Comment: Likely `MailsShouldBeWellReceived` is a better contract candidate as it have tests testing the mail content is well stored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
