Arsnael commented on code in PR #2495: URL: https://github.com/apache/james-project/pull/2495#discussion_r1855893494
########## server/blob/blob-s3/src/main/java/org/apache/james/blob/objectstorage/aws/S3BlobStoreConfiguration.java: ########## @@ -230,7 +269,9 @@ public final boolean equals(Object o) { && Objects.equals(this.writeTimeout, that.writeTimeout) && Objects.equals(this.connectionTimeout, that.connectionTimeout) && Objects.equals(this.uploadRetrySpec, that.uploadRetrySpec) - && Objects.equals(this.specificAuthConfiguration, that.specificAuthConfiguration); + && Objects.equals(this.specificAuthConfiguration, that.specificAuthConfiguration) + && Objects.equals(this.ssecEnabled, that.ssecEnabled) + && Objects.equals(this.ssecConfiguration, that.ssecConfiguration); Review Comment: Sorry I mixed up the two PRs with the comment for some reason, forget it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org