jeantil commented on code in PR #2569:
URL: https://github.com/apache/james-project/pull/2569#discussion_r1894692283
##########
protocols/netty/src/main/java/org/apache/james/protocols/netty/ProtocolMDCContextFactory.java:
##########
@@ -96,7 +96,6 @@ static MDCBuilder from(Object o) {
static MDCBuilder forSession(ProtocolSession protocolSession) {
return MDCBuilder.create()
.addToContext(MDCBuilder.SESSION_ID,
protocolSession.getSessionID())
- .addToContext(MDCBuilder.CHARSET,
protocolSession.getCharset().displayName())
Review Comment:
@chibenwa @Arsnael I want to point this out and make sure you have seen it
and agree with it.
If I keep it, I end up with the charset mdc attribute being set twice in a
single log, unfortunately this makes both logback-classic and logback-contrib
json serializer fail to output the log. instead it outputs a message on STDERR
I have not been able to reproduce this locally in a test, I tried various
things such as changing the builder to make sure to clear the MDC and
deduplicate the keys manually before writing them back: without success.
removing this line systematically fixes the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
