chibenwa commented on code in PR #2569:
URL: https://github.com/apache/james-project/pull/2569#discussion_r1894697984


##########
protocols/netty/src/main/java/org/apache/james/protocols/netty/ProtocolMDCContextFactory.java:
##########
@@ -96,7 +96,6 @@ static MDCBuilder from(Object o) {
     static MDCBuilder forSession(ProtocolSession protocolSession) {
         return MDCBuilder.create()
             .addToContext(MDCBuilder.SESSION_ID, 
protocolSession.getSessionID())
-            .addToContext(MDCBuilder.CHARSET, 
protocolSession.getCharset().displayName())

Review Comment:
   Seems legit to me.
   
   The charset info seems to be kinda low value...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org

Reply via email to