jeantil commented on code in PR #2902:
URL: https://github.com/apache/james-project/pull/2902#discussion_r2694809628
##########
mailbox/plugin/deleted-messages-vault-cassandra/src/main/java/org/apache/james/vault/metadata/StorageInformationDAO.java:
##########
@@ -47,15 +47,15 @@ public class StorageInformationDAO {
private final PreparedStatement addStatement;
private final PreparedStatement removeStatement;
private final PreparedStatement readStatement;
- private final BlobId.Factory blobIdFactory;
+ private final BlobIdTimeGenerator blobIdTimeGenerator;
@Inject
- StorageInformationDAO(CqlSession session, BlobId.Factory blobIdFactory) {
+ StorageInformationDAO(CqlSession session, BlobIdTimeGenerator
blobIdTimeGenerator) {
this.cassandraAsyncExecutor = new CassandraAsyncExecutor(session);
this.addStatement = prepareAdd(session);
this.removeStatement = prepareRemove(session);
this.readStatement = prepareRead(session);
- this.blobIdFactory = blobIdFactory;
+ this.blobIdTimeGenerator = blobIdTimeGenerator;
Review Comment:
>This would mean acting at the blobStoreDAO level and not on the BlobStore.
:thinking: not sure I follow : it does require creating a custom blobstore
instance but it has no impact on the blobstoreDAO itself. This is how we did it
for the [blob backed
mailrepository](https://github.com/apache/james-project/blob/master/server/mailrepository/mailrepository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepositoryFactory.scala#L55)
It could arguably be managed at the injection layer by using a Qualified
blobid factory instance ( this is a limitation of the BlobMailRepositoryFactory
which forces usage of a passthrough blobstore and cannot use deduplication but
I was so happy to have something working I stopped without the deduplication,
also deduplication makes less sense for a mail repository which I don't expect
to store mails for years )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
