chibenwa commented on code in PR #2902:
URL: https://github.com/apache/james-project/pull/2902#discussion_r2694775374
##########
mailbox/plugin/deleted-messages-vault-cassandra/src/main/java/org/apache/james/vault/metadata/StorageInformationDAO.java:
##########
@@ -47,15 +47,15 @@ public class StorageInformationDAO {
private final PreparedStatement addStatement;
private final PreparedStatement removeStatement;
private final PreparedStatement readStatement;
- private final BlobId.Factory blobIdFactory;
+ private final BlobIdTimeGenerator blobIdTimeGenerator;
@Inject
- StorageInformationDAO(CqlSession session, BlobId.Factory blobIdFactory) {
+ StorageInformationDAO(CqlSession session, BlobIdTimeGenerator
blobIdTimeGenerator) {
this.cassandraAsyncExecutor = new CassandraAsyncExecutor(session);
this.addStatement = prepareAdd(session);
this.removeStatement = prepareRemove(session);
this.readStatement = prepareRead(session);
- this.blobIdFactory = blobIdFactory;
+ this.blobIdTimeGenerator = blobIdTimeGenerator;
Review Comment:
Hello @jeantil
-> I wonder if this piece of coude could not work with PlainBlobId as the
cassandra implem is blobId transparent. That's a technical nitpick that do not
address the core of your remarks but could be a nice simplification I presume.
Worth testing...
> a custom BlobId.Factory implementation
On the principle mostly agree. This would mean acting at the blobStoreDAO
level and not on the BlobStore. Which do not seem like a major issue to me.
I;ll try to push a fix in this direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
