felixauringer commented on PR #2773: URL: https://github.com/apache/james-project/pull/2773#issuecomment-3768917166
> > Those tests would be better located in OidcJwtTokenVerifierTest now in my opinion. Do you agree? > > Those tests are likely to be duplicated with SMTP and IMAP? > > +1 I tend to agree. I think that the tests are currently not duplicated but moving them makes it clearer what exactly they test: the authentication logic which is now more centralized. I would move some of these authentication tests, and also use the documentation form your latest aud-branch, Benoit. This will probably happen only on the coming weekend but definitely this week :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
