chibenwa commented on code in PR #2960:
URL: https://github.com/apache/james-project/pull/2960#discussion_r2916460921
##########
server/blob/blob-aes/src/main/java/org/apache/james/blob/aes/AESBlobStoreDAO.java:
##########
@@ -102,9 +102,11 @@ public InputStream read(BucketName bucketName, BlobId
blobId) throws ObjectStore
}
@Override
- public Publisher<InputStream> readReactive(BucketName bucketName, BlobId
blobId) {
- return Mono.from(underlying.readReactive(bucketName, blobId))
- .map(Throwing.function(this::decrypt));
+ public Publisher<InputStreamBlob> readBlobReactive(BucketName bucketName,
BlobId blobId) {
+ return Mono.from(underlying.readBlobReactive(bucketName, blobId))
+ .map(InputStreamBlob::payload)
+ .map(Throwing.function(this::decrypt))
+ .map(InputStreamBlob::of);
Review Comment:
Yes indeed. I focussed so far on adding the metadata to the interface, not
on making it work correctly.
Given an agreement on the design, I'd be happy to spend the 1 week to
complete the work along with decent amount of testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
