jeantil commented on code in PR #2960:
URL: https://github.com/apache/james-project/pull/2960#discussion_r2925224174
##########
server/blob/blob-api/src/main/java/org/apache/james/blob/api/BlobStoreDAO.java:
##########
@@ -19,86 +19,128 @@
package org.apache.james.blob.api;
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
import java.io.InputStream;
-import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
import java.util.Collection;
+import java.util.Map;
import org.reactivestreams.Publisher;
+import com.google.common.collect.ImmutableMap;
import com.google.common.io.ByteSource;
+import com.google.common.io.FileBackedOutputStream;
public interface BlobStoreDAO {
- class ReactiveByteSource {
- private final long size;
- private final Publisher<ByteBuffer> content;
+ record BlobMetadataName(String name) {
Review Comment:
at the very least do you mind hiding the Map type in a Metadata type ? and
exposing a readonly api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
