> +      server.enqueue(addCommonHeaders(new 
> MockResponse().setResponseCode(204)));
> +
> +      try {
> +         KeystoneApi keystoneApi = api(server.getUrl("/").toString(), 
> "openstack-keystone");
> +         RoleAdminApi roleAdminApi = keystoneApi.getRoleAdminApi().get();
> +         roleAdminApi.delete("r1000");
> +
> +         assertEquals(server.getRequestCount(), 3);
> +         assertAuthentication(server);
> +         assertExtensions(server);
> +         RecordedRequest updateRoleRequest = server.takeRequest();
> +         assertEquals(updateRoleRequest.getRequestLine(), "DELETE 
> /OS-KSADM/roles/r1000 HTTP/1.1");
> +      } finally {
> +         server.shutdown();
> +      }
> +   }

There are tests for the happy path, but the API methods also define behaviors 
(fallbacks) for error responses. The corresponding mock tests should also be 
added.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/303/files#r10011814

Reply via email to