Thanks for the contribution @pnavarro! Most comments are minors. Nice job!

Some general comments:

* Add mock tests for the failed requests to verify that the configured 
`@Fallback` are producing the expected results.
* Add unit tests for the `*Options` class that implement `MapBinder`, to verify 
they properly generate the request payload. You can have a look at [this 
package](https://github.com/jclouds/jclouds/tree/master/core/src/test/java/org/jclouds/rest/binders)
 to see how you can implement binder unit tests.
* Consider changing the "nullable" primitive booleans to Boolean objects to 
avoid unexpected NPEs.
* Consider throwing a `SkipException` in the setup methods of those tests that 
require the API to be present in all tests. This will give better feedback in 
the test report.

Nice job, btw. It's good to see you contributing here! :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/303#issuecomment-35943105

Reply via email to